typeorm: tests are not closing the connection when failing

aspecto-io / opentelemetry-ext-js

js extensions for the open-telemetry project

https://www.aspecto.io

Apache License 2.0

172 stars 40 forks source link

typeorm: tests are not closing the connection when failing #168

Open blumamir opened 3 years ago

blumamir commented 3 years ago

typeorm tests are creating a new db connection in each test. If something goes wrong (assertion fails, exception thrown), the test does not close this connection which causes the following tests to fail as well. We need to move the logic into afterEach hook so tests clean the environment after they are done for whatever reason.

Madhavkumar-04 commented 4 weeks ago

hii, can i start working on this @blumamir