search

aspectron / hydrogen

JSX OpenGL Interface Module
1 stars 0 forks source link

F11 switch causes screen to blink #6

Open aspectron opened 10 years ago

aspectron commented 10 years ago

When hitting F11 in thorium, the entire display blinks. I am not sure what is causing this. The behavior of maximizing app full-screen should not be different then hitting "maximize" and "restore" buttons (i.e. window re-sizing) with exception of window going topmost (i.e. or above taskbar).

pmed commented 10 years ago

I suppose this may be caused by the UI browser resize in carbon.js:143

BTW it seems, I fixed full screen toggling in aspectron/oxygen@5cd45e325bd4548ae4a7b8f06c5cec9b07f4c7c3

aspectron commented 10 years ago

No, the entire display blinks. I have 3 monitors. When going full-screen all 3 monitors blink to black and back. Really strange. Might be something OpenGL related. I will investigate later on.

pmed commented 10 years ago

I'd like to create a new release before with the fix in Oxygen.

pmed commented 10 years ago

Please this it in version 0.3.20. Fullscreen toggling doesn't work in the last Carbon version, I got an error in console:

No such action: FULL SCREEN
aspectron commented 10 years ago

My bad. Fixed: https://github.com/aspectron/carbon/commit/ed9b007255130f20f88d459a18f0ec9f0e1e7e44

For reference, take a look at https://github.com/aspectron/carbon/blob/master/actions.js#L81 and https://github.com/aspectron/carbon/blob/master/actions.js#L196

Make a note of that as this allows one to easy introduce test functionality and bind it to a specific key.