aspectumapp / osm2geojson

Convert OSM and Overpass XML/JSON to GeoJSON
MIT License
100 stars 14 forks source link

Reconsider `highway=service` in Polygon Whitelist #1

Closed mykolakozyr closed 5 years ago

mykolakozyr commented 5 years ago

Description

There is highway=service in Polygon Whitelist, while "The tag highway=service predominantly describes a linear feature of a routable way. When mapped as a closed polygon without any further tagging, it describes a linear, circular way and not an area." [OSM Wiki]

In cases using service= tag with highways, it is usually used with the following tags (all of them are linear objects [OSM Wiki]:

The issue appeared with no possibility to transform bridges geometry to lines due to the conditions described.

Proposed solution

Remove highway=service from Polygon Whitelist

rapkin commented 5 years ago

I found in OSM documentation two types of tags:

This is important in our case. As you can see in this lib I use polygon-features.json to detect polygons: https://github.com/tyrasd/osm-polygon-features/blob/65e0a1e290675877e8cdd007efcefc35a7dfe0dc/polygon-features.json . And there is only highway=services in whitelist (this is correct by OSM documentation).

If you have any problem with polygons generation, please, describe your problem with example.

mykolakozyr commented 5 years ago

My fault :)