Several huge improvements

[davispuh]

• Removed bundled Doctrine (which was pretty old)
• Added Composer, so this package can be easily installed
• Changed file locations and namespaces (now it's \Fuel\Doctrine which I think it's much better)
• Improved Logger class, now it works correctly with specific data types like DateTime and Objects
• Extended configuration options so it uses Fuel db.php and also supports all options. (no need to manage 2 files for database settings)
• Database options are very customizable. With inheritance. (even more powerful than Fuel offers)
• Removed doctrine2.php as this config isn't needed anymore since everything is in db.php
• Removed phpquickprofiler.php because it's not required. All queries are correctly shown with proper EXPLAIN detals
• Improved README with detailed description and configuration information.
• Maybe more...

Tested with newest FuelPHP 1.6/develop and works perfectly :)

Also consider adding this package to Composer package list https://packagist.org/

It has never been so simple to add Doctrine to FuelPHP: composer install is all that's required and start using it immediately \Fuel\Doctrine::manager();

[jimcottrell]

Thanks. I'll check this out. This repository was kind of a test that didn't really get updated, and I switched active development to another location, so there was probably some duplication of effort. I should have been counting more on people discovering it. Anyway, our project using Fuel with Doctrine came to an end, but I'm sure there are others who can benefit from your work.

[davispuh]

Well, this repo is first hit in Google. And seems perfect ;)

If you see what else can be improved that would be great. Actually I'm using this some time already. I was just little improved it for my own needs (like logger). But decided to share and improved other things also. It really made much easier integration. And now I think it's so easy as there can't be easier :D Only if have to migrate from previous version then will need do search & replace Doctrine_Fuel:: with \Fuel\Doctrine::

Thank You for this awesome package :)

[jimcottrell]

Okay, so I've had a chance to go through your pull request, and I can't merge it directly as written, but it's inspired some changes, which I've committed to the branch for this request (pr/2).

Some issues and notes:

• I don't feel that you've taken advantage of FuelPHP's cascading config files, so I've rewritten the connection settings to use that rather than re-implementing a form of cascading. It loses a little bit of flexibility but gains clarity, I think.
• Along with that, I like the idea of just using the db.php config and not having a separate config, but I wanted some separation to make it clear that these are not standard FuelPHP options, so I've placed settings in a 'doctrine2' key
• I'm not sure why you chose to essentially re-implement Doctrine's newDefaultAnnotationDriver() function, but you couldn't have been using the annotation driver, because CachedReader's constructor requires a parameter you weren't sending.
• Composer is great, but hadn't taken off when I created this, so certainly I'll go forward with this as a Composer package, but I don't think symfony/yaml should be a required dependency, and I felt like we should probably be pulling stable libraries from Doctrine.
• I've committed the reworked Logger from my original project. I'm sure your changes work, but I prefer the idea of letting the DBAL type system escape values
• I think that ArrayCache should be used by default, and it seems like 'enable_cache' for SQL queries is a little different than what Doctrine does, so I didn't like using it for this package. Caching will always be on but only ArrayCache unless another driver is specified
• I've tried to clarify the documentation beyond what you've added

I'd appreciate any further thoughts you have, or if you see an obvious problem with what I've changed here, just let me know. If everything seems good though, I'll merge this to master and submit to Packagist.

Thanks for your changes!

[davispuh]

looks awesome :) While for me it seemed great idea about config that it can be overloaded at any level. Thus no need to duplicate some settings if you've lots of different connections which all could be used in same application it does make it bit complicated. So maybe this is better indeed.

About annotation driver it was somewhat untested experiment with customization. Sorry it was there.

yaml there wasn't intentionally, I just copied those requirements from app I'm making.

Changes to Logger was kind of a hacks I would say. Just when I started using this it didn't worked for several data types. Also I just found another issue with Logger. Take a look at last commit. I'll have to try with this to see if it have such issue.

For testing it seemed good idea to disable cache completely but I guess maybe it's not so good idea.

Documenting and explaining isn't my strong side so there you've done perfectly. Now it's much easier to understand.

I think you broke charset, because in FuelPHP it's in configuration but outside of connection. While for Doctrine DBAL it expects it to be in connection thus should copy it from above level if it's not there.

[davispuh]

just checked with this Logger it works perfectly, there's no such issue :) So thanks for it, nice ;)

EDIT: by issue I mean about INSERT queries..

[jimcottrell]

You're right, I definitely broke charset. It should be taken care of. I'm going to merge these changes to master at this point. Thanks for your contributions!

[davispuh]

great :) I would also suggest to add a tag so composer will pick it as version and I'm sure users would love seeing it in Packagist ;)

[jimcottrell]

Done and done.