search

asphyxia-core / plugins

Community Plugins for Asphyxia CORE
176 stars 76 forks source link

[SDVX] Change ap_card and submonitor_bg jpeg to denoised png #49

Closed amane-ame closed 1 year ago

amane-ame commented 2 years ago

All pngs have been compressed by FileOptimizer.

dannylin0711 commented 2 years ago

Instead of uploading the files to this repo, the plugin structure would change to specify user directory and get assets from the game, webui won't preload with these files in the future.

amane-ame commented 2 years ago

So when will be the future…? Is there a planned releasing time point?在 2022年6月7日，18:13，LatoWolf @.***> 写道： Instead of uploading the files to this repo, the plugin structure would change to specify user directory and get assets from the game, webui won't preload with these files in the future.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

dannylin0711 commented 2 years ago

Not sure yet, plus asphyxia not yet fully complete with new API Freddie is making right now, so we'll have to wait.

TsFreddie commented 2 years ago

We don't know. I've tried to make filesystem access in CORE which didn't turn out to be convenient or sensible.

Another idea is to just upload them in a CDN and load them over the air, but that would partially defeat the offline nature of plugins. Maybe a toggle and a warning would work. (Do note that CDN access can track users, like email images do, which isn't ideal for some people.)

Either way I'm not convinced to make plugins three times bigger just to get some better images in WebUI.

dannylin0711 commented 2 years ago

That's why I try to reduce the size with smaller dimension jpgs instead of using compressed pngs, and yes, I would rather try not to make those assets any bigger,

anjing-puteh commented 2 years ago

getting the images (except for the skill level) should be fine but it's not going to be easy for options like custom bgm because it's a .s3p file.