aspiers / git-deps

git commit dependency analysis tool
GNU General Public License v2.0
299 stars 47 forks source link

git-deps fails to work with Flask >= 2.2 (safe_join has been removed in Flask) #110

Closed zorun closed 2 years ago

zorun commented 2 years ago

I installed git-deps via pip, and it fails to start in server mode:

$ git deps -s
Cannot find flask module which is required for webserver mode.

After some debugging, it turns out that the safe_join import fails because that function has just been removed from Flask: https://github.com/pallets/flask/issues/4516

Since git-deps does not pin constrain the dependency on flask, it pulls the latest available version.

The workaround I'm using for now is:

$ pip install 'flask<2.1'
imwcc commented 2 years ago

I meet a same issue

aspiers commented 2 years ago

Thanks a lot for the report and the fix!