search

aspiers / git-deps

git commit dependency analysis tool
GNU General Public License v2.0
298 stars 47 forks source link

don't fork git merge-base #2

Open aspiers opened 9 years ago

aspiers commented 9 years ago

It should be possible to replace invocations of git merge-base with calls to the pygit2 API. This should speed things up a bit.

aspiers commented 9 years ago

Looks like proper merge-base support has only just reached libgit2 so won't be supported by pygit2 for a while.

waldyrious commented 7 years ago

According to https://github.com/libgit2/pygit2#0220-2015-01-16, it looks like pygit2 adopted that version of libgit2 only a few days after this issue was submitted :) But you know that, since you commented on https://github.com/libgit2/pygit2/pull/459, so I'm confused now about whether that's the right release.

In any case, I suppose since then the change has indeed propagated to pygit2 regardless. Should the "blocked" label be removed from this issue?

aspiers commented 7 years ago

Yep, thanks :)