search

aspiers / git-deps

git commit dependency analysis tool
GNU General Public License v2.0
299 stars 47 forks source link

graph: adjacent rows sometimes get inverted when adding nodes #21

Open aspiers opened 9 years ago

aspiers commented 9 years ago

I think this is probably a bug in webcola because the separation constraints look fine. The odd thing is that

d3cola.start()

seems to always turn it up the right way again.

aspiers commented 9 years ago

Not seeing this any more since 284b0ca7 - assuming fixed.

aspiers commented 9 years ago

ARGH. This just happened again, right in the middle of a demo video I was recording :-(

qinfchen commented 9 years ago

Is it because of your row_alignment_constraint logic? It is saying that the adjacent nodes on the same row can have this y range. 

node[left].y - 100 <= node[right].y <= node[right].y + 100

why is it needed? shouldn't the y difference between two adjacent nodes be 0?

aspiers commented 9 years ago

No if it was zero then there would be no flexibility at all, and flexibility is often useful. It is possible that 100 is too high though.