aspiers / git-deps

git commit dependency analysis tool
GNU General Public License v2.0
298 stars 47 forks source link

Account for Diff API changes in pygit2 version 0.22.1. #58

Closed Valodim closed 8 years ago

Valodim commented 8 years ago

Signed-off-by: Michael Stefaniuc mstefani@winehq.org

This cleanly applied with git am, but noone filed a PR so far so I just did that. Please merge to make git-deps work with newer versions of pygit2 :+1:

aspiers commented 8 years ago

Thanks very much! I would like to merge, but I would also like to keep backwards-compatibility if possible, and I guess it should not be too hard to detect API version via introspection within the code, via hasattr / ismethod or similar. Would you be able to do this? If not I can try to find time, but it might not be soon.

aspiers commented 8 years ago

Well, I gave it a try but the for loop was just complicated enough that I lost patience for the idea of keeping backwards-compatibility. I guess even 0.22.x is fairly old at this point anyway. So I'm merging this.