search

aspiers / git-deps

git commit dependency analysis tool
GNU General Public License v2.0
298 stars 47 forks source link

Explicitly require python2 #59

Closed Emantor closed 8 years ago

Emantor commented 8 years ago

Some distributions (e.g. Arch Linux) switched to python3 as the default python interpreter, this changes git-deps to explicitly require python2 (and thus work with Arch Linux ootb).

aspiers commented 8 years ago

OK thanks, although I'm in the process of converting this to a proper Python module, at which point it might support both 2 and 3. Can you explain what exactly fails with Python 3?

Emantor commented 8 years ago 
$python3 git-deps.py
Traceback (most recent call last):
  File "git-deps.py", line 280, in <module>
    class InvalidCommitish(StandardError):
NameError: name 'StandardError' is not defined

Looking at the python 3.5 docs it seems StandardError does no longer exist in Python3.

aspiers commented 8 years ago

Ah OK, thanks!

Emantor commented 8 years ago

The rabbit hole is definitly deeper, fixing the exception leads to some str buffer errors, but I guess this needs a new issue :)