jstma
commented
9 months ago ffmpeg and timidity both have location variables, so only one more would be needed to find lilypond.
I forgot to mention above that I had to take the version string out of my .ly file because it couldn't find convert-ly.py. Even though it found lilypond just fine. The error was this:
Version in test.ly: 2.2.0
Will convert to: 2.24.3
Path not found.
Generating PNG and MIDI files ...
------------------------------------------------------------
GNU LilyPond 2.24.3 (running Guile 2.2)
005b:err:combase:RoGetActivationFactory Failed to find library for L"Windows.Management.Deployment.PackageManager"
warning: cannot find file: `C:\users\notme\Temp\ly2videoijevlt7g\converted.ly'
fatal error: failed files: "C:\\users\\notme\\Temp\\ly2videoijevlt7g\\converted.ly"It exists in the same lilypond/bin directory as lilypond.exe, but I suppose it doesn't work because file associations aren't set up. There is python.exe in that directory (with lilypond and convert-ly.py) and
python convert-ly.pyworks from the command line. The python command works everywhere when lilypond's path is in the path.
A flag of some kind to indicate whether to call convert-ly.py or python convert-ly.py would be good. Or maybe test for the first and if it fails also try the second?
aspiers
Using ly2video on Windows seems hard. I've only tried it via Wine.
I know github can package python projects into an exe, but I figured I'd try it locally first. Eventually, it could become a github action to ease the pain of using it on windows. The same could be done for linux if it made sense.
In a new wineprefix, I installed python, ly2video requirements, and auto-py-to-exe (pyinstaller). This created an executable from ly2video.git that ran under wine. That was easy and doesn't require the end user to have python installed
However, the external dependencies, lilypond, ffmpeg, and timidity, are a bit of a pain.
Neither lilypond or ffmpeg, come with installers. That means you have to place them somewhere and tell ly2video where they are via the PATH variable. Then timidity has the same problem, but doesn't come with any soundfonts.
On Ubuntu anyway, you can just "apt-get install tmidity" and it will play midi right out of the box. On Windows, it's a different story.
On Ubuntu timidity uses the FluidR3_GM.sf2 soundfont. It's available in various places.
Since timidity is a bear to install on windows (for someone less savvy), it would be nice to provide a working zip file with timidity and the soundfont ready to go. I don't know if it's in the scope of ly2video to host that soundfont. There is another project that has the soundfont in a sister repo where they are added as Release artefacts. Because they are too big to commit to github:
https://github.com/pianobooster/fluid-soundfont/releases
It's a one time operation. Then I guess a github action could wrap them into a zip file.
To make timidity work on Windows, I borrowed the timidity.cfg from my machine with slight modification. Running ly2video in wine produces a video file with sound. So it works, but there's also an error message at the end:
The temp directory is deleted so I don't know what that error means yet.
I think some solutions might involve telling ly2video where lilypond and ffmpeg are installed, like is done for timidity. And then providing a way to install timidity along with ly2video. It might also be a good idea to add a config file and look for it in the directory where ly2video is. Then ly2video could be deployed as a bundle, pulling from the release builds of lilypond, ffmpeg, and timidity. Maybe this is done in a sister repo.
Lastly, it might be easier to let the user make the audio file however they want and then pass that file in through a command line argument. Is there any reason this can't be done?