search

aspiers / opensuse-spotify-installer

Automate installation of Spotify on openSUSE
80 stars 29 forks source link

Adapt to spotify-make, #2 #17

Closed leamas closed 11 years ago

leamas commented 11 years ago

Should fix all open issues from previous one.

Here's a catch: the install-spotify.sh script relies on the content of opensuse-spotify-installer on github. Since this is yet not complete from the scripts point of view, the script uses my fork. This is in INST_REPO at top of script. this should be updated before merged.

aspiers commented 11 years ago

Awesome! I'll take a look.

leamas commented 11 years ago

I have some more fixes pending (spotify-client.spec changelog, library paths, bug above), but I'll wait until I know if you have more to add.

leamas commented 11 years ago

Ping?

aspiers commented 11 years ago

Sorry, been horrendously busy. Keep pestering if I don't review soon ;-)

aspiers commented 11 years ago

Thanks a lot for your continued work on this which is mostly fantastic - I think we are very close now! Please don't be discouraged by my comments which may seem overly critical for such a small project (and as a result might be annoying), but I am regrettably short of free time for this stuff, so when code changes aren't grouped into 100% logically related commits it does make the whole review process much harder and slower.

aspiers commented 11 years ago

I'm trying to fix the remaining issues now. Let's see how far I get.

aspiers commented 11 years ago

I have fixed some of the issues with your series and pushed to my spotify-make branch - please use that as a basis for future work. However I have still not managed a single successful run with this version, so clearly it's not ready for end users yet. But we are pretty close now I think!

leamas commented 11 years ago

Prepering a new request, closing