search

aspiers / opensuse-spotify-installer

Automate installation of Spotify on openSUSE
80 stars 29 forks source link

Automatically insert version into spec files #34

Closed mthuurne closed 9 years ago

mthuurne commented 10 years ago

Use placeholders in the spec files and have the install-spotify.sh script inject the version and release number into them. This way, only one file needs to be updated on version bumps.

aspiers commented 9 years ago

Thanks a lot for the idea, and sorry it took me so long to look at this. I agree that avoiding duplication of version numbers is a good idea, however AFAICS your changes don't take care of doing the substitution on spotify-installer.spec, and that would actually be impossible because that package wraps around install-spotify.sh. #37 eliminates the same duplication, plus it offers several other nice improvements, so I think we should focus efforts on that instead.