search

aspiers / stow

GNU Stow - mirror of savannah git repository occasionally with more bleeding-edge branches
http://www.gnu.org/s/stow/
GNU General Public License v3.0
650 stars 41 forks source link

Remove dependencies on Hash::Merge and Clone::Choose #60

Closed aspiers closed 5 years ago

aspiers commented 5 years ago

stow 2.3.0 added external runtime dependencies on Hash::Merge and Clone::Choose. Historically stow hasn't had runtime dependencies other than Perl itself, which is a useful property if you're managing the installation of Perl using stow; the bootstrapping instructions in stow's manual would need updating to describe how to install these two modules (and any dependencies they have now or in the future) as well.

However, Hash::Merge is much more general than stow actually needs, so replace the merge() call with a few lines of equivalent code -- this avoids the external dependencies, and is clearer than the merge() call.

Many thanks to Adam Sampson for this patch:

https://lists.gnu.org/archive/html/bug-stow/2019-06/msg00001.html

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.08%) to 86.312% when pulling 9ce10eb3b1cee35906baf1daea8eccc43a4e6623 on rm-hash-merge into 7eb1a0c57be74e17cf87a2b8c87a2c23a509880e on master.

OverkillGuy commented 5 years ago

Hello, Can we get a tag of release 2.3.1 from master, so this change is available for downstream package managers?

If tagged, this would fix https://github.com/termux/termux-packages/issues/4114, but I doubt downstream would accept using a build from a branch (even master).

aspiers commented 5 years ago

Yep will try to find time for this soon!

aspiers commented 5 years ago

2.3.1 is now released.