search

aspiers / stow

GNU Stow - mirror of savannah git repository occasionally with more bleeding-edge branches
http://www.gnu.org/s/stow/
GNU General Public License v3.0
650 stars 41 forks source link

`stow --simulate` should warn when `-v` is not specified #82

Open ilyagr opened 3 years ago

ilyagr commented 3 years ago

At the default verbosity level, --simulate is quite useless, which confused me (see https://github.com/aspiers/stow/issues/81).

I think that either --simulate should imply -v, or the warning --simulate prints should be modified when the verbosity level is 0. It could say something like:

WARNING: in simulation mode so not modifying filesystem.
WARNING: The verbosity level is 0. Simulation results will not be shown.
aspiers commented 3 years ago

That's a great idea - thanks!

ilyagr commented 3 years ago

Glad to hear it! I also thought of slightly better wording:

WARNING: The verbosity level is 0. Use --verbose to see simulation results.

Thanks for maintaining stow, by the way!

gutierri commented 3 years ago

I believe it would be better in case of invoking --simulate the default verbose value is 1 and always accept >= 1. Because the idea of the functionality is to visualize what would happen (right?).

Needing to fill in another parameter for this to work, can be a bit complicated. I even found out that --simulate is not on the manpage (#86).

aspiers commented 3 years ago

@gutierri commented on April 15, 2021 1:32 AM:

I believe it would be better in case of invoking --simulate the default verbose value is 1 and always accept >= 1. Because the idea of the functionality is to visualize what would happen (right?).

Yes I think I agree, and aim to do this for the next release - unless you want to submit a PR ;-)

aspiers commented 5 months ago

All the critical work for 2.4.0 took WAY longer than I expected, so unfortunately I didn't get round to this yet; pushing to 2.4.1.

gutierri commented 5 months ago

No problem!

Em 7 de abril de 2024 20:20:56 BRT, Adam Spiers @.***> escreveu:

All the critical work for 2.4.0 took WAY longer than I expected, so unfortunately I didn't get round to this yet; pushing to 2.4.1.

-- Reply to this email directly or view it on GitHub: https://github.com/aspiers/stow/issues/82#issuecomment-2041641920 You are receiving this because you commented.

Message ID: @.***>