search

aspineux / pyzmail

Pyzmail is a high level mail library for Python, providing functions to read, compose and send emails
60 stars 31 forks source link

Pip install requires deprecated distribute package (Python3.3) #3

Closed Duologic closed 7 years ago

Duologic commented 10 years ago

An install of pyzmail with pip fails to install. Output similar to this forum post: http://forum.magiksys.net/viewtopic.php?f=19&t=189 Workaround requires installing the deprecated distribute package, as said in above forum post.

As I can understand, the code requires this to convert code with 2to3.py. Why not rewrite the code to conform to Python3.x specification?

I will look into this, if code is valuable for my project, I'll probably start a fork to rewrite the code, or maybe find someone beating me to it... :-)

Duologic commented 10 years ago

Just used the converted scripts, not much changed, seems to work on 2.7.6 and 3.3.5, also removed the distribute_setup as no longer needed. Should be tested more on both python versions, for what it's worth I will be using it on a Python 3.x project.

aspineux commented 10 years ago

Thanks for you input. I spend a lot of time to make pyzmail works on both 2.X and 3.X, having doctest and regressions test working. The careful use of u"unicode string" in the doctest and in the code to keep compatibility required a lot of efforts. I need time to evaluate your patch, but at first it looks like it break the doctest. Compatibility with 3.3 is important, I'll try to take a look quickly.

Regards

Duologic commented 10 years ago

Great job on the library, Python 3.4 came out this week. The email module has had updates too, the multipart stuff is working better now. Not sure if I still need pyzmail, but I'll keep it in mind.