aspirebudgetingmobile / aspirebudgeting_ios

An independent community driven app for the Aspire Budget Google Sheet
GNU General Public License v3.0
54 stars 14 forks source link

Mathwani/file validator #100

Closed mohitathwani closed 4 years ago

mohitathwani commented 4 years ago

Performs FileValidation when selected from file list

mohitathwani commented 4 years ago

Add tests for FileValidtor and AppDefaults

mohitathwani commented 4 years ago
1 Warning
:warning: Big PR

Generated by :no_entry_sign: Danger

codecov-commenter commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master2@2eaec59). Click here to learn what that means. The diff coverage is 85.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master2     #100   +/-   ##
==========================================
  Coverage           ?   47.15%           
==========================================
  Files              ?       62           
  Lines              ?     2341           
  Branches           ?        0           
==========================================
  Hits               ?     1104           
  Misses             ?     1237           
  Partials           ?        0           
Impacted Files Coverage Δ
...pire Budgeting/Facilities/GoogleDriveManager.swift 97.36% <ø> (ø)
Aspire Budgeting/Views/AspireMasterView.swift 0.00% <0.00%> (ø)
...pire BudgetingTests/GoogleSheetsManagerTests.swift 0.00% <ø> (ø)
Aspire Budgeting/Facilities/AppDefaults.swift 14.81% <20.00%> (ø)
Aspire Budgeting/Facilities/AppCoordinator.swift 66.66% <50.00%> (ø)
Aspire BudgetingTests/MockSpreadsheet.swift 60.00% <60.00%> (ø)
Aspire Budgeting/Facilities/FileValidator.swift 91.30% <91.30%> (ø)
...re BudgetingTests/GoogleSheetsValidatorTests.swift 96.96% <96.96%> (ø)
Aspire Budgeting/Facilities/ObjectFactory.swift 96.42% <100.00%> (ø)
Aspire BudgetingTests/MockUser.swift 100.00% <0.00%> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2eaec59...028b3b7. Read the comment docs.