search

aspirebudgetingmobile / aspirebudgeting_ios

An independent community driven app for the Aspire Budget Google Sheet
GNU General Public License v3.0
54 stars 14 forks source link

Publisher based Sign In Flow #147

Closed mohitathwani closed 3 years ago

mohitathwani commented 3 years ago

Refactors the sign in flow in a more Combine way

github-actions[bot] commented 3 years ago
4 Warnings
:warning: Big PR
:warning: Consider to place some MARK: lines for files over 200 lines big.
:warning: Aspire Budgeting/AppDelegate.swift#L17 - Consider using final for this class or use a struct (final_class)
:warning: Aspire BudgetingTests/GoogleContentManagerTests.swift#L11 - Consider using final for this class or use a struct (final_class)

Generated by :no_entry_sign: Danger

codecov-commenter commented 3 years ago

Codecov Report

Merging #147 (345fe7c) into master (3a74bb8) will increase coverage by 42.87%. The diff coverage is 52.40%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #147       +/-   ##
===========================================
+ Coverage        0   42.87%   +42.87%     
===========================================
  Files           0       87       +87     
  Lines           0     3237     +3237     
===========================================
+ Hits            0     1388     +1388     
- Misses          0     1849     +1849
Impacted Files Coverage Δ
Aspire Budgeting/AppDelegate.swift 80.00% <ø> (ø)
...re Budgeting/Facilities/GoogleContentManager.swift 73.48% <0.00%> (ø)
...dgeting/Facilities/LocalAuthorizationManager.swift 0.00% <0.00%> (ø)
...re Budgeting/Facilities/Publisher+Extensions.swift 0.00% <0.00%> (ø)
...ire Budgeting/Preview Content/MockAuthorizer.swift 0.00% <ø> (ø)
Aspire Budgeting/Preview Content/MockUser.swift 100.00% <ø> (ø)
...e Budgeting/ViewModels/FileSelectorViewModel.swift 0.00% <0.00%> (ø)
Aspire Budgeting/Views/AccountBalancesView.swift 0.00% <0.00%> (ø)
Aspire Budgeting/Views/AspireMasterView.swift 0.00% <0.00%> (ø)
Aspire Budgeting/Views/AspireSegmentedView.swift 0.00% <ø> (ø)
... and 110 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3a74bb8...345fe7c. Read the comment docs.