aspirebudgetingmobile / aspirebudgeting_ios

An independent community driven app for the Aspire Budget Google Sheet
GNU General Public License v3.0
54 stars 14 forks source link

Adding os_log #68

Closed mohitathwani closed 4 years ago

mohitathwani commented 4 years ago

Incorporating unified logging

codecov-io commented 4 years ago

Codecov Report

Merging #68 into master will increase coverage by 1.2%. The diff coverage is 74.24%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #68     +/-   ##
=========================================
+ Coverage   70.38%   71.59%   +1.2%     
=========================================
  Files          46       46             
  Lines        1344     1468    +124     
=========================================
+ Hits          946     1051    +105     
- Misses        398      417     +19
Impacted Files Coverage Δ
Aspire Budgeting/Facilities/StateManager.swift 98.55% <100%> (+0.4%) :arrow_up:
Aspire Budgeting/Models/DashboardMetadata.swift 100% <100%> (ø) :arrow_up:
...pire BudgetingTests/GoogleSheetsManagerTests.swift 88.54% <100%> (ø) :arrow_up:
...re Budgeting/Facilities/GoogleSDKCredentials.swift 100% <100%> (ø) :arrow_up:
...dgeting/Facilities/LocalAuthorizationManager.swift 42.42% <25%> (-7.58%) :arrow_down:
...ire Budgeting/Facilities/GoogleSheetsManager.swift 56.8% <64.15%> (+7.11%) :arrow_up:
Aspire Budgeting/Facilities/UserManager.swift 89.47% <81.81%> (-2.42%) :arrow_down:
...pire Budgeting/Facilities/GoogleDriveManager.swift 91.52% <83.33%> (-2.1%) :arrow_down:
Aspire Budgeting/SceneDelegate.swift 84.21% <0%> (+5.26%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4f9a587...2c67185. Read the comment docs.

mohitathwani commented 4 years ago
2 Warnings
:warning: Consider to place some MARK: lines for files over 200 lines big.
:warning: Aspire Budgeting/Facilities/GoogleSheetsManager.swift#L232 - Function should have 5 parameters or less: it currently has 6
function_parameter_count GoogleSheetsManager.swift:232

Generated by :no_entry_sign: Danger