search

aspiredu / django-safemigrate

Safely run migrations before deployment
MIT License
68 stars 0 forks source link

Rename enums for clarity and pep8 #63

Closed ryanhiebert closed 1 month ago

ryanhiebert commented 1 month ago

This one is not urgent. IMO, it would be fine to release this in a minor version upgrade.

PEP 8 spoke that we should use ALL_CAPS for enum values, but I was too stubborn to get on board. In this I hope to lower my stubbornness by switching this in these internal APIs. And rename our enums to have a bit clearer semantic meaning that I hope will be easier to digest.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (7798942) to head (3de2104).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #63 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 6 6 Lines 188 185 -3 Branches 43 42 -1 ========================================= - Hits 188 185 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.