aspirepress / AspireUpdate

A plugin that allows for rewriting the URLs used to fetch updates from WordPress.org to some other endpoint
15 stars 4 forks source link

WPCS compliance #9

Open smileBeda opened 3 days ago

smileBeda commented 3 days ago

Pull Request

What changed?

Why did it change?

Compliance with WPCS grants greater readability and broader adoption of code. Further this PR serves to eliminate a majority of the scanner's warnings (both WPCS and my custom sonar cloud so I can in a 2nd pr (rename methods) and a third pr (review code flow) eventually ensure nothing is left unsafe.

Did you fix any specific issues?

the only changes that can theoretically affect functionality are using wp_parse_url over parse_url and using strict array comparison as well as strict if block comparisons. The rest is just renaming, should not affect functionality.