search

aspnet-contrib / AspNet.Security.OAuth.Providers

OAuth 2.0 social authentication providers for ASP.NET Core
Apache License 2.0
2.37k stars 535 forks source link

List of providers migrated #182

Closed kinosang closed 6 years ago

kinosang commented 6 years ago

As #170, this issue is for tracking the works to migrate all the providers to Asp.Net Core 2.0.

kevinchalet commented 6 years ago

Added Patreon to the list (the 1.x provider was merged today).

kevinchalet commented 6 years ago

List of providers that have been merged into the experimental branch:

haydenhancock commented 6 years ago

I can work on a couple of these:

asadsahi commented 6 years ago

@kinosang @PinpointTownes I can't locate the correct nuget package. Is experimental upgrade available as package somewhere that I can try for .net core 2.0.

Thanks

kinosang commented 6 years ago

@asadsahi There's no experimental upgrade available on nuget nor aspnet-contrib myget gallery at this time. But I've created a feed on myget and published some providers, you can have a look at https://www.myget.org/feed/Packages/aspnetcore-authentication.

Additional, you can find the nupkg files at https://ci.appveyor.com/project/aspnet-contrib/aspnet-security-oauth-providers/branch/experimental/artifacts.

asadsahi commented 6 years ago

@kinosang thanks for sharing this. I have got LinkedIn working in my project, but for some reason Challenging with Github doesn't redirect to github site. can't figure out why. The only thing I have provided in github setup is:

   .AddGitHub(options =>
               {
                   options.ClientId = Startup.Configuration["Authentication:Github:ClientId"];
                   options.ClientSecret = Startup.Configuration["Authentication:Github:ClientSecret"];

               })

Have you tried github?

kinosang commented 6 years ago

@asadsahi I didn't tried the GitHub provider. Is there any exception or error message when you test it?

asadsahi commented 6 years ago

@kinosang Its a little bit weird, I am getting a little clear error now, When I print all the schemes registered in the system, it can see clearly github is added. e.g

with this code:

    @foreach (var provider in ViewBag.schemes)
    {
         <strong>@provider.Name</strong><br>
    }

it prints out:

image

But when I navigate using github link i get

image

Doesn't give any build errors during github registration either.

kinosang commented 6 years ago

@asadsahi The AuthenticationScheme.Name should be "GitHub", not "Github", check if you have changed the default value.

asadsahi commented 6 years ago

Right, sorry, I did some refactoring yesterday, where I must have mistyped it. I have corrected it to GitHub with capital 'H', and now I am on the same issue I was having yesterday. let me grab few screenshots.

This is what is passed in when challenging with github providers:

image

Can't spot any different compared with LinkedIn. But just doesn't navigate to github comes straight to local site.

this is linked in request: image

Jenan commented 6 years ago

If I want to use the middleware for Github with .NET Core 2.0 - which package is it required to download? Thx.

asadsahi commented 6 years ago

@Jenan for now the package is on myget, I have following nuget.config at the root of of my project:

nuget.config:

<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <packageSources>
    <add key="NuGet" value="https://api.nuget.org/v3/index.json" />
    <add key="aspnet-contrib" value="https://www.myget.org/F/aspnet-contrib/api/v3/index.json" />
    <add key="aspnet-contrib-auth" value="https://www.myget.org/F/aspnetcore-authentication/api/v3/index.json" />
    <add key="AspNetCore" value="https://dotnet.myget.org/F/aspnetcore-ci-dev/api/v3/index.json" />
  </packageSources>
</configuration>

Package you need is :

<PackageReference Include="AspNet.Security.OAuth.GitHub" Version="2.0.0-*" />

asadsahi commented 6 years ago

@kinosang I have manage to get github working. It was wrong callback url setup on github. Working as expected.

Thanks.

kevinchalet commented 6 years ago

@haydenhancock do you plan to port the other providers you listed in the near future? Ideally, I'd like to finalize the RC2 bits this week and push them to NuGet.org next week... people keep asking for the 2.0 providers :sweat_smile:

kevinchalet commented 6 years ago

@kinosang I know you've already contributed massively to the 2.0 port, but would you be interested in porting the 5 remaining providers?

(I'll clone @haydenhancock's PR locally and fix the inconsistencies so we can finally merge it)

kinosang commented 6 years ago

@PinpointTownes ok, I'll make it.

haydenhancock commented 6 years ago

Sorry guys. I haven't had a chance to make these changes.

On Mon, Nov 20, 2017 at 9:30 AM, Chino Chang notifications@github.com wrote:

@PinpointTownes https://github.com/pinpointtownes ok, I'll make it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers/issues/182#issuecomment-345711828, or mute the thread https://github.com/notifications/unsubscribe-auth/AAmMrnQv-wdFNoL01FBflwbznp4na0OWks5s4YzxgaJpZM4PoyUy .

-- Hayden Hancock HaydenHancock@gmail.com

kinosang commented 6 years ago

All providers migrated.

aspnetcore-authentication feed will be removed.

Thx.

kevinchalet commented 6 years ago

I'll remove the hack we used to make the 1.0/2.0 providers live together in the same solution and merge the experimental branch into dev. Nightly builds should be available later today.

We'll give folks a few days (maybe 1 week?) to try them before pushing them to NuGet.org.

kevinchalet commented 6 years ago

Great news: the 46 aspnet-contrib OAuth2 social providers have been migrated to #aspnetcore 2.0. Special thanks to everyone who helped and kudos to Chino Chang who ported 37 providers! The packages can be downloaded from our #myget feed: https://www.myget.org/F/aspnet-contrib/api/v3/index.json

https://twitter.com/PinpointTownes/status/935240112954400769