search

aspnet-contrib / AspNet.Security.OAuth.Providers

OAuth 2.0 social authentication providers for ASP.NET Core
Apache License 2.0
2.38k stars 538 forks source link

Upgrade Autodesk to v2 #764

Closed EMostafaAli closed 1 year ago

EMostafaAli commented 1 year ago

Update Autodesk provider for v2 https://aps.autodesk.com/en/docs/oauth/v2/developers_guide/overview/ Issue: #760

kevinchalet commented 1 year ago

Note: you forgot to update the address of the userinfo endpoint to use the v2 userinfo API. See https://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers/pull/788/files.

EMostafaAli commented 1 year ago

Isn't it done as per the following screenshot? image

kevinchalet commented 1 year ago

@EMostafaAli I don't see this change in this PR:

image

Are you sure you pushed the changes to the correct branch?

(also, you'll likely need to update the claim mapping in the options class)

EMostafaAli commented 1 year ago

My bad, I was looking at different code. I will try to make the changes quickly.

EMostafaAli commented 1 year ago

@kevinchalet , updated the user info endpoint

kevinchalet commented 1 year ago

@EMostafaAli it looks like you didn't fix the points mentioned by @martincostello. We'll also need you to fix https://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers/pull/764#discussion_r1241017181 before being able to merge this PR.

EMostafaAli commented 1 year ago

@kevinchalet, I hope this new commit addresses your comments.

martincostello commented 1 year ago

The tests are failing.

EMostafaAli commented 1 year ago

@martincostello, Done