search

aspnet-contrib / AspNet.Security.OAuth.Providers

OAuth 2.0 social authentication providers for ASP.NET Core
Apache License 2.0
2.35k stars 533 forks source link

Change InstagramAuthenticationDefaults.cs to InstagramDefaults.cs #779

Closed AbdulrahmanXSO25 closed 1 year ago

AbdulrahmanXSO25 commented 1 year ago

I have error when using this package that I've Controllers with this name "InstagramAuthenticationDefaults", so I changed it to "InstagramDefaults"

kevinchalet commented 1 year ago

Thanks for your PR.

Doing so would be a major breaking change for all the users of this package, so it's not an option. Instead, if you have a class with the same name, consider renaming it or using aliases.

AbdulrahmanXSO25 commented 1 year ago

I've did this already!😅

But it was very boring for me to edit all the project, as the files is too many, but the right is that I can't modify the package classes' names as you said.

Thank you kevin!

Also, I've a mini question if you don't matter.. As this was my first pull request here, you said "PR" for pull request, is that correct?

kevinchalet commented 1 year ago

Also, I've a mini question if you don't matter.. As this was my first pull request here, you said "PR" for pull request, is that correct?

Yep, that's correct 😃