search

aspnet-contrib / AspNet.Security.OAuth.Providers

OAuth 2.0 social authentication providers for ASP.NET Core
Apache License 2.0
2.34k stars 533 forks source link

Use unified BattleNet server #813

Closed martincostello closed 7 months ago

martincostello commented 8 months ago

Implemented based on https://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers/issues/812#issuecomment-1789607922.

Unless it's because of my office's DNS, I couldn't get oauth.battlenet.com.cn to resolve, so I left the URLs for China as they were.

I don't actually have a BattleNet account so I haven't tested this against the actual server.

Resolves #812.

kevinchalet commented 8 months ago

Unless it's because of my office's DNS, I couldn't get oauth.battlenet.com.cn to resolve, so I left the URLs for China as they were.

Yeah, I noticed the same thing when testing the OpenIddict implementation. It just seems this domain name - that has a CNAME entry that points to AWS China - is not resolvable everywhere: https://www.whatsmydns.net/#CNAME/oauth.battlenet.com.cn

martincostello commented 7 months ago

I figured it was better to let people just switch the region so if they de-split it again, then we don't need to change anything in the code at all, people just change their Region value back to one of the original ones. If we change all the field values and they de-unify, then we need to do a new release to change them back again.

I figured this was a good middle ground of back-compat and not preventing the use of the unified regions at all.

kevinchalet commented 7 months ago

Yeah, it's a reasonable compromise 👍🏻