search

aspnet-contrib / AspNet.Security.OAuth.Providers

OAuth 2.0 social authentication providers for ASP.NET Core
Apache License 2.0
2.34k stars 533 forks source link

Support for the new LinkedIn API version format #834

Closed softwareolatomiwa closed 3 weeks ago

softwareolatomiwa commented 4 months ago

New Apps created on LinkedIn returns with Error 403 on getting user details using the /me endpoint. The endpoint has been changed and scope also has been changed to include openid, profile and email

ALso the format of user data returned has changed.

https://www.linkedin.com/developers/news/featured-updates/openid-connect-authentication

martincostello commented 4 months ago

Can you also confirm that this all works as expected with the real live LinkedIn API?

kevinchalet commented 4 months ago

Given it's technically a behavior breaking change - that requires subscribing to the new OIDC-based service - it would probably make more sense to bump the minor version (i.e 8.1 instead of 8.0.1). We'll also need to mention that clearly in the release notes.

softwareolatomiwa commented 4 months ago

@martincostello I confirm it works as expected with the real live LinkedIn API

thang-d commented 3 weeks ago

Hi @martincostello I think we should complete it ASAP; we are having trouble with LinkedIn authentication

martincostello commented 3 weeks ago

It would probably make more sense to bump the minor version (i.e 8.1 instead of 8.0.1).

@kevinchalet So do you want to re-version everything as 8.1.0 for releasing this?

kevinchalet commented 3 weeks ago

@kevinchalet So do you want to re-version everything as 8.1.0 for releasing this?

Yeah, that would be better.

In the same vein, we should probably bump the minor version instead of the patch version when introducing new features/providers: only bumping the patch version is something we had to do when ASP.NET Core had minor versions (as we wanted to have matching major+minor versions), but it's no longer necessary now that .NET never increases its minor version.

martincostello commented 3 weeks ago

OK - once I merge the open PRs, I'll do a follow up to update 8.0.1 to 8.1.0 before doing the release, and then I'll do patch or minor going forwards depending on what's in the release.

martincostello commented 3 weeks ago

Thanks for your contribution @softwareolatomiwa - these changes are now available in version 8.1.0.