aspnet-contrib / AspNet.Security.OAuth.Providers

OAuth 2.0 social authentication providers for ASP.NET Core
Apache License 2.0
2.4k stars 542 forks source link

Implement Docusign OAuth provider #907

Closed denis-goncharenko closed 5 months ago

denis-goncharenko commented 5 months ago

This feature allows users to authenticate using their Docusign credentials. Tested in production service and works perfectly.

kevinchalet commented 5 months ago

Tested in production service and works perfectly.

Isn't https://account-d.docusign.com/ DocuSign's dev environment?

We'll need to add an Environment option to allow users to change the environment without having to replace each endpoint manually to use https://account.docusign.com/ instead of https://account-d.docusign.com/.

denis-goncharenko commented 5 months ago

Tested in production service and works perfectly.

Isn't https://account-d.docusign.com/ DocuSign's dev environment?

We'll need to add an Environment option to allow users to change the environment without having to replace each endpoint manually to use https://account.docusign.com/ instead of https://account-d.docusign.com/.

You are right. It's my fault I've just tested in prod and then in sandbox and forgot to change it.

I'll add the 'Environment' option.

denis-goncharenko commented 5 months ago

I've included the 'Environment' option to facilitate work with development and production environments. I have tested both options, and they work as expected.

martincostello commented 5 months ago

Could you update the version for 8.2.0 here please as we're adding a new provider?

https://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers/blob/5319292ae8606ae2a9ae58afb56386c5e2257d82/eng/Versions.props#L5-L6

Otherwise LGTM.

denis-goncharenko commented 4 months ago

Hello @martincostello! When are you planning to create NuGet packages for version 8.2.0?

martincostello commented 4 months ago

910 is still WIP so assumed we'd do the release when that was finished too.