search

aspnet-contrib / AspNet.Security.OpenIdConnect.Samples

ASP.NET Core samples demonstrating how to use the OpenID Connect server with MVC or JS apps
64 stars 31 forks source link

Current samples Vs OpenIdConnect.Server/samples #12

Closed BrainCrumbz closed 8 years ago

BrainCrumbz commented 8 years ago

How do samples in this current project compare to those found in OpenIdConnect.Server/samples?

At least for the Mvc one, which is the one to follow?

Thank you

kevinchalet commented 8 years ago

The samples on the main repository always target the latest ASP.NET Core/aspnet-contrib bits (RC3 for the dev branch, RC2 for the release one) while this repository targets the latest stable release (RC1).

BrainCrumbz commented 8 years ago

Would it make sense to unify all of them under this Samples project, maybe split into a Stable and a Dev/Latest/Unstable subdirectories?

kevinchalet commented 8 years ago

Would it make sense to unify all of them under this Samples project, maybe split into a Stable and a Dev/Latest/Unstable subdirectories?

It would make my work more painful, since I use the samples to ensure we don't break interoperability with the MSFT OIDC client when implementing new features.

BrainCrumbz commented 8 years ago

I see. I think we can throw two more PRs to the table, one for each project, commenting on those differences

kevinchalet commented 8 years ago

Thanks for your contribution :clap:

Done: https://github.com/aspnet-contrib/AspNet.Security.OpenIdConnect.Samples/commit/71ca6995d8641a7912463147a8cc0f45a6dbdd44.

BrainCrumbz commented 8 years ago

Great. As mentioned, probably we'll submit two small PRs soon with those differences.