search

aspnet / AspNetKatana

Microsoft's OWIN implementation, the Katana project
Apache License 2.0
960 stars 331 forks source link

Re-do the build infrastructure #445

Closed Tratcher closed 2 years ago

Tratcher commented 2 years ago

This is a complete replacement of the build infrastructure:

Follow ups:

Cut:

Note, a lot of this was copied from reverse-proxy and aspnetcore, there are likely things that could be removed. Please let me know if you spot any.

dougbu commented 2 years ago

Oh, that's odd. Why does this repo have an official pipeline but nothing to validate public PRs❔

dougbu commented 2 years ago
  • Release automation
  • Publishing build artifacts to a feed
  • Symbol publishing
  • PR validation
  • Subscribe for Arcade updates

Much of this list is external to the repo. Publishing is handled by adding a Maestro++ (darc) default channel and Arcade updates come through a Maestro++ subscription for example.

Tratcher commented 2 years ago

Oh, that's odd. Why does this repo have an official pipeline but nothing to validate public PRs❔

The CI used to be provided by old services that have been discontinued. Replacing it wasn't a priority given this project is in maintenance mode. It should be easier now that we're back on current infrastructure.

wtgodbe commented 2 years ago

Oh, that's odd. Why does this repo have an official pipeline but nothing to validate public PRs❔

I think @Tratcher just has to create one on https://dev.azure.com/dnceng/public/_build and link it to the .yml file - docs: https://github.com/dotnet/arcade/blob/main/Documentation/AzureDevOps/MovingFromDevDivToDncEng.md, https://github.com/dotnet/arcade/blob/main/Documentation/AzureDevOps/AzureDevOpsGuidance.md#pipelines. You should also set up the mirror bot to mirror the github repo to the azdo repo if you haven't already