aspnet / AspNetKatana

Microsoft's OWIN implementation, the Katana project
Apache License 2.0
967 stars 333 forks source link

Removed if for port from OwinHttpListener #460

Closed abatishchev closed 2 years ago

abatishchev commented 2 years ago

Correct me if I'm wrong but since port is defaulted to 5000 if not present then the if always true and can be safely omitted, hence the concatenation moved into the final expression.

abatishchev commented 2 years ago

Can port be empty or whitespace string? I.e. be present in the dictionary and not default to 5000. Then the if is necessary and the PR is void and null.