search

aspnet / AspNetKatana

Microsoft's OWIN implementation, the Katana project
Apache License 2.0
967 stars 333 forks source link

Supress CodeQL warnings #484

Closed Tratcher closed 1 year ago

Tratcher commented 1 year ago

These were mostly false positives with the exception of SM02185, server certificate revocation checks, which enabling now would be a breaking change. Customers can enable this themselves. I cleared this with @blowdart.

dougbu commented 1 year ago

Need to use a newer build agent. See https://helix.dot.net/ for available choices. If you can use 1es-windows-2019-open, do (it's a bit more streamlined). Otherwise, windows.vs2019.amd64.open. You don't need .pre anymore.

Separately, have you filed bugs on CodeQL3000 about the false positives❔ Probably also worth filing bugs about the horribad suppression syntax.