Fix Component governance bugs

[wtgodbe]

Could not find AzureStorageEmulator.exe. Please install Azure SDK from http://azure.microsoft.com/en-us/downloads/

@MattGal @dotnet/dnceng the build used to work on these machines, have they changed? https://github.com/aspnet/AspNetWebHooks/blob/5f384bda295a112b0788dad5992376d1781857ee/.azure-ci.yml#L33-L34

[MattGal]

Could not find AzureStorageEmulator.exe. Please install Azure SDK from http://azure.microsoft.com/en-us/downloads/

@MattGal @dotnet/dnceng the build used to work on these machines, have they changed?

https://github.com/aspnet/AspNetWebHooks/blob/5f384bda295a112b0788dad5992376d1781857ee/.azure-ci.yml#L33-L34

Taking a look, it looks like @dnceng tagging isn't working in this repo for some reason.

[MattGal]

@wtgodbe:

You can get info about what changes in 'windows-latest' from commit history here. Most recent thing that I know of is moving from 2019 being default to 2022.

To the un-asked questions, there's two things going on here.

• In general, you need to stop using AzDO Hosted builds
• The pool provider mentioned in your yaml is long dead (I'm thinking this build hasn't run in some time?)

So assuming you wanted to address both (feel free to do either/or; some folks may talk to you about continued hosted usage though), it'd be something like going from:

    pool:
    vmImage: windows-latest
    ${{ if ne(variables['System.TeamProject'], 'public') }}:
      # This override makes the specified vmImage irrelevant.
      name: NetCoreInternal-Pool
      queue: BuildPool.Server.Amd64.VS2017

... to:

    pool:
    ${{ if eq(variables['System.TeamProject'], 'public') }}:
      name: NetCore1ESPool-Public
      demands: ImageOverride -equals build.windows.10.amd64.vs2017.open
    ${{ if ne(variables['System.TeamProject'], 'public') }}:
      name: NetCore1ESPool-Internal
      demands: ImageOverride -equals build.windows.10.amd64.vs2017

All available 1ES Hosted build images are listed in https://helix.dot.net/, I've picked VS 2017 ones since that seems to be what you had before. We also mirror the "Azure hosted" VS 2019 and VS 2022 images (via 1es-windows-2019/1es-windows-2022) if VS 2019 is acceptable ; latest is VS 2022 for sure.

[wtgodbe]

Thanks @MattGal - trying that now