aspnet / AspNetWebStack

ASP.NET MVC 5.x, Web API 2.x, and Web Pages 3.x (not ASP.NET Core)
Other
858 stars 354 forks source link

NuGet Package : Add `repository` metadata. #190

Closed MaximRouiller closed 6 years ago

MaximRouiller commented 6 years ago

Basically, we can now add a repository metadata on a nuspec file to allow the repository to be surfaced on NuGet. This allows you to have a projectUrl as well a repository URL now.

I've talked about it on Twitter but the most basic things to know is here:

NuSpec Reference

Reference Implementation in Json .NET image

natemcmaster commented 6 years ago

cc @Eilon - we do this already on ASP.NET Core packages. I think it's worth adding to older nuspec's. No need to trigger a new release for this, but next time there is a release, it would be good to have this in the package metadata.

Eilon commented 6 years ago

Yeah I'm fine with that.

MaximRouiller commented 6 years ago

@natemcmaster are you doing the PR or should I?

natemcmaster commented 6 years ago

Feel free to send a PR. @Eilon who services this repo and could help bring in the change?

MaximRouiller commented 6 years ago

@natemcmaster @Eilon does https://github.com/aspnet/AspNetWebStack/blob/master/Directory.Build.props makes sense to you as to where I should add it to have it imported into everything?

Eilon commented 6 years ago

@mkArtakMSFT runs this repo, and @dougbu is the main expert.

dougbu commented 6 years ago

Feel free to send a PR to change src/WebApiHelpPage/WebApiHelpPage.nuspec and src/WebApiHelpPage/VB/WebApiHelpPage.VB.nuspec. We appreciate the help.

We'll handle the remaining packaging which is in an internal repository.

MaximRouiller commented 6 years ago

@dougbu whenever you're ready.

dougbu commented 6 years ago

Thanks @MaximRouiller

dougbu commented 6 years ago

2109e7e082 takes care of this repository. Remaining work is in internal packages.

dougbu commented 6 years ago

Remainder done in changeset 1728218

MaximRouiller commented 6 years ago

@dougbu Thank you so much!

cc @spboyer