search

aspnet / AspNetWebStack

ASP.NET MVC 5.x, Web API 2.x, and Web Pages 3.x (not ASP.NET Core)
Other
858 stars 354 forks source link

Localized Microsoft.AspNet.WebPages.Data packages do not provide correct resources #324

Closed dougbu closed 2 years ago

dougbu commented 2 years ago

Since https://www.nuget.org/packages/Microsoft.AspNet.WebPages.Data.fr/3.1.0 and similar packages were published, the contained assembly has been named WebMatrix.WebData.resources.dll. This does not line up w/ the WebMatrix.Data.dll assembly in https://www.nuget.org/packages/Microsoft.AspNet.WebPages.Data/3.1.0. That initially just looked confusing.

The problem is much worse because the misnamed assembly is actually identical to what we ship in e.g. https://www.nuget.org/packages/Microsoft.AspNet.WebPages.WebData.fr/3.1.0. That doesn't do much good for .Data users.

Resources found in Microsoft.AspNet.WebPages.Data localized packages: WebMatrix Data resources

Versus those found in the base assembly: WebMatrix Data resources

Further, the namespaces don't match either (base image second): WebMatrix Data resourceNames

dougbu commented 2 years ago

Fixed in TFS changeset 1770739. Should be able to publish 3.2.9 / 5.2.9 containing this fix next week (Memorial Day may delay things).