Move NetCore project to use .NET SDK

[dougbu]

Move NetCore project to use .NET SDK

• Formatting.NetCore now targets netstandard1.3
  • was Profile259 aka portable-net45+wp80+win8+wpa81, approximately netstandard1.0
  • but Newtonsoft.Json.Bson supports netstandard1.3 and up
• use Newtonsoft.Json.Bson in NetCore projects
• can now multi-target NetCore.Test as well
• nits:
  • align src/ Formatting projects as much as possible
  • align test/ Formatting projects as much as possible
  • clean up the Microsoft.TestCommon project slightly
• note: NetCore project names make no sense but I'm leaving them alone for this PR

React to using Newtonsoft.Json.Bson everywhere

• remove deprecated BsonWriter mentions entirely
• remove legacy BSON writer test workaround

Remove unnecessary ConcurrentDictionary class

• was not available in Profile259
• leave tests to confirm correct operation w/ "real" class

Remove UriQueryUtility because WebUtility is available everywhere

• leave test to confirm WebUtility continues to behave about the same
  • handle WebUtility being a public class
• change other tests to handle WebUtility.UrlEncode(...) encoding to uppercase
  • unlike UriQueryUtility.UrlEncode(...)

Add simple classes to NetCore project

• use ICloneable copy to get more classes compiling
  • helps NetCore in similar way to existing MediaTypeHeaderValueExtensions
• use InvalidEnumArgumentException copy to simplify code and testing
• both not available in netstandard1.3 (or available packages) but easily duplicated

Remove unnecessary NetCore-specific GlobalSuppressions.cs file

Use NameValueCollection everywhere

• available (but not serializable) in netstandard1.3

Add MaxDepth support in NetCore assembly

• remove an unnecessary suppression about MaxDepth in BaseJsonMediaTypeFormatter

Add UseDataContractJsonSerializer support in NetCore assembly

• XsdDataContractExporter remains unavailable
  • update XML DCS tests to handle this (previously not in NetCore assembly)
• try various workarounds
  • ReadOnlyStreamWithEncodingPreamble causes tests to hit dotnet/runtime#80160
  • restriction to UTF8 when writing is a significant issue

Copy TranscodingStream and related files from dotnet/runtime

• my runtime clone was at 88868b7a781f4e5b9037b8721f30440207a7aa42

Adjust TranscodingStream and related code to compile and run here

• add conditions to avoid references to version-specific API
• remove references to internal dotnet/runtime code
  • rewrite some code more generically if performance impact likely minor
• use Microsoft.TestCommon instead of directly relying on Xunit in tests
• use C# 9.0

Use TranscodingStream in JSON and XML formatters

• remove ReadOnlyStreamWithEncodingPreamble and its tests
  • was insufficient in general and doesn't work correctly in netstandard1.3
  • see dotnet/runtime#80160
• now support a much broader set of encodings in JSON and XML formatters
  • not just UTF8, UTF16BE, and UTF16LE
  • JSON formatter already supported every encoding when UseDataContractJsonSerializer was false
  • no longer have this downside when property is true
  • however, quotas remain unsupported in netstandard1.3 version of this formatter when property is true
  • XML formatter requirement for an XML declaration in non-UTF8 content was general and is no longer an issue

Add MediaTypeMappings support in NetCore assembly

Add IRequiredMemberSelector support in NetCore assembly

Remove unnecessary NETFX_CORE workarounds

• use DefaultContractResolver, GuidAttribute, TypeDescriptor, XmlElement, XmlNode classes
• use IRequiredMemberSelector interface
• use RequestMessage.CreateResponse() extension method
  • all available in netstandard1.3
• JsonContractResolver use is something of a late Newtonsoft.Json version reaction
  • was held back by missing IRequiredMemberSelector

Work around missing features in netstandard1.3

• get classes now included in NetCore assembly compiling
• SerializationAttribute is not available
  • therefore Exception is not serializable
  • therefore DefaultContractResolver.IgnoreSerializableAttribute is not available
• Stream.(Begin|End)(Read|Write) and Stream.Close() are not available
• nit: clean up MultipartFormDataStreamProvider whitespace

Ensure a couple more assemblies are available

• don't seem to be copied into test folder in CI builds

[dougbu]

This PR is pretty big and complicated. I recommend going through the commits individually and concentrating on areas you're at least slightly familiar with.

@phenning, I included you because I'm removing some comments you added. Note we already have a netstandard2.0 assembly w/ none of the restrictions of the former Profile259 assembly.

@stephentoub and @GrabYourPitchforks, you're likely most interested in the first two of the three commits mentioning TranscodingStream, especially the middle one.

[dougbu]

To help track which commits have been thoroughly checked, please tick those you are signing off on:

• [x] Move NetCore project to use .NET SDK
• [x] React to using Newtonsoft.Json.Bson everywhere
• [x] Remove unnecessary ConcurrentDictionary class
• [x] Remove UriQueryUtility because WebUtility is available everywhere
• [x] Add simple classes to NetCore project
• [x] Remove unnecessary NetCore-specific GlobalSuppressions.cs file
• [x] Use NameValueCollection everywhere
• [x] Add MaxDepth support in NetCore assembly
• [x] Add UseDataContractJsonSerializer support in NetCore assembly
• [x] Copy TranscodingStream and related files from dotnet/runtime
• [x] Adjust TranscodingStream and related code to compile and run here
• [ ] Use TranscodingStream in JSON and XML formatters
• [x] Add MediaTypeMappings support in NetCore assembly
• [x] Add IRequiredMemberSelector support in NetCore assembly
• [x] Remove unnecessary NETFX_CORE workarounds
• [x] Work around missing features in netstandard1.3
• [x] Ensure a couple more assemblies are available (fixup for "Adjust TranscodingStream ..." commit)
• [x] !fixup! Remove added AggressiveInlining requests
• [ ] !fixup! Improve XmlReader comments

[dougbu]

/ping reviewers

[dougbu]

Rebased and addressed @stephentoub's comments.

@stephentoub any other thoughts❔ If none, please check the non-NameValueCollection commits off in the earlier checklist that aren't checked yet. They're all TranscodingStream related but I understand if parts aren't of interest to you. We could find someone to double-check the project files for example (if you prefer).

Other reviewers: Please look at the NameValueCollection commit.

[stephentoub]

please check the non-NameValueCollection commits off in the earlier checklist that aren't checked yet. They're all TranscodingStream related but I understand if parts aren't of interest to you. We could find someone to double-check the project files for example (if you prefer).

I don't have rights to click those checkmarks. I only reviewed the "Adjust TranscodingStream and related code to compile and run here" commit and it looked fine other than my feedback you addressed.

[dougbu]

I don't have rights to click those checkmarks.

That's a bit odd but thanks for letting me know where you'd focused. Much appreciated.

[dougbu]

To other reviewers: I also ticked the checkboxes for "Copy TranscodingStream …" because that was just a literal cp from my dotnet/runtime clone and "!fixup! Remove added AggressiveInlining requests" because that was in response to @stephentoub's comments. This leaves us w/ 3 unreviewed commits.

[dougbu]

@Tratcher I addressed your comment on the "Use TranscodingStream …" commit in the latest "!fixup!" commit. Would you say you're signing off on those two commits❔

Still one open question on versioning and public API surface to you @Tratcher

[Tratcher]

I've reviewed everything but the tests. :shipit: