aspnet / AzureIntegration

[Archived] Features that integrate ASP.NET Core with Azure. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
24 stars 20 forks source link

AppModelDetector.Detect returns DotNetFramework for nondeterministic / empty folder #140

Closed soninaren closed 5 years ago

soninaren commented 6 years ago

Can we add default return type to be Unknown or something similar in case it is nondeterministic?

pakrym commented 6 years ago

What are the criteria to categorize folder as the desktop framework?

soninaren commented 6 years ago

I am not sure how can that be determined. But right now the API is returning DotNet Framework for anything that is not DotNetCore or DotNetCoreStandalone. For now i figured it would be nice have that fixed.

pakrym commented 6 years ago

I would be glad to do changes but we have to decide on rules/scenarios of what we detect as nondeterministic

soninaren commented 6 years ago

As if now to me, Anything that cannot be categorized as DotNetCore or DotNetCoreStandalone would fall under nondeterministic category.

muratg commented 5 years ago

We don't expect to do any changes here.