search

aspnet / AzureIntegration

[Archived] Features that integrate ASP.NET Core with Azure. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
24 stars 20 forks source link

Remove NETStandard.Library dependency from Microsoft.Web.Xdt.Extensions #39

Closed Tratcher closed 7 years ago

Tratcher commented 7 years ago

NETStandard.Library is pulled in by common.props but Microsoft.Web.Xdt.Extensions is a .NET 4.5.1 library only and doesn't need it.

muratg commented 7 years ago

Do we want to do this in preview1? IOW, is anything broken, or is this clean-up?

Tratcher commented 7 years ago

Nothing's broken that we're aware of, but the dependency leaks to our site extension and to app insight's site extension.

Tratcher commented 7 years ago

AppInsights is broken by this:

2017-05-04T21:40:05.3681660Z   The 'Microsoft.NETCore.Platforms 1.1.0' package requires NuGet client version '2.12' or above, but the current NuGet version is '2.8.60318.667'.
2017-05-04T21:40:05.3681660Z   Unable to find version '2.0.0-preview1-24847' of package 'Microsoft.Web.Xdt.Extensions'.
2017-05-04T21:40:05.3681660Z   Unable to find version '2.0.0-preview1-25301-01' of package 'NETStandard.Library'.
2017-05-04T21:40:05.3681660Z   The 'System.Runtime.InteropServices.RuntimeInformation 4.3.0' package requires NuGet client version '2.12' or above, but the current NuGet version is
muratg commented 7 years ago

So is the fix only removing NETStandard.Library? And it's almost no-risk since this is only supposed to run in .NET Framework. Let's do this and unblock AppInsights.

cc @Eilon

Tratcher commented 7 years ago

I removed it manually from the signed package. They won't pick up a new build until we have the signing figured out.