search

aspnet / BasicMiddleware

[Archived] Basic middleware components for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
169 stars 84 forks source link

IPNetwork Parse/TryParse and common networks #101

Closed moander closed 7 years ago

moander commented 8 years ago
dnfclas commented 8 years ago

Hi @moander, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

moander commented 8 years ago

IPAddress.Parse behaves differently on OS X.

https://github.com/dotnet/corefx/issues/11843

Tratcher commented 8 years ago

Please update the samples to show the new APIs

davidfowl commented 8 years ago

We're not going to take a dependency on immutable collections for what seems like a such an obscure use case.

muratg commented 8 years ago

@moander Could you sign the CLA if you agree with the changes proposed?

dnfclas commented 8 years ago

Hi @moander, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

muratg commented 8 years ago

Closed/reopend to trigger the CLA bot

muratg commented 7 years ago

@moander, thanks for sending this PR. Closing this one as this is quite stale right now. Please file a bug if you'd like to bring this back to discussion.