Clean up response compression

[Tratcher]

Open items:

• More convenient Options
  • Compression providers
  • Compression negotiator
• accept-encoding q-value negotiation (perf)
• should mime types be case sensitive? (No)
• Make sure no negotiation happens / no bytes written if there's no body.
• Flush
• Exception
• Hook ISendFileFeature?
• API Review

Testing:

• How much buffering does the gzip stream do? 8kb
• Integration test with WebListener, Kestrel,
• IIS/Express
• nginx https://github.com/aspnet/BasicMiddleware/issues/123
• Perf https://github.com/dotnet/corefx/issues/12549

Release:

• [x] Bump version from 0.1.0 to 1.0.0 when ready

[muratg]

Putting in 1.1.0 for now. We can move it to 1.2.0 if we can't finish this off in time.

[Tratcher]

GZipStream allocations: https://github.com/dotnet/corefx/issues/12549

[muratg]

@Tratcher Per PM decision, version numbers for new packages will be 1.0.0-preview1 for the initial release. (Not 1.1.0-preview1)

[Tratcher]

Review feedback:

• [x] Should the services be registered as singleton or transient? Eilon said Singleton.
• [x] Split ResponseCompressionExtensions by services vs appbuilder.
• [x] Rename EnableHttps to EnableForHttps
• [x] Try binding Options from Config
• [x] Configurable services should resolve their own options rather than being instantiated, configured, and registered as instances.
• [x] See how MVC adds filters, something about adding the type to am list on options and then creating the type from DI.
• [x] Remove the AddResponseCompression(params string[]) overload, investigate defaults and wildcards instead. Text/*, Application/javascript. https://github.com/aspnet/BasicMiddleware/issues/121

[Tratcher]

Reading from config works pretty well:

{
  "section": {
    "EnableForHttps": true,
    "MimeTypes": ["text/plain", "text/html"]
  }
}

            services.AddResponseCompression(options =>
            {
                Configuration.GetSection("section").Bind(options);
            });

[Tratcher]

Possible default mime types (things used by the template, static files): text/css text/html application/javascript

WebApi: application/xml text/xml application/json text/json application/json-patch+json

Other: text/plain

[Yves57]

Maybe adding "image/svg+xml" to the default types.

[Tratcher]

@Yves57 justification? We're not trying to capture every possible type, just the ones to make the 90% scenario work. I based this list on the files included in the full WebApp template, as well as those types from MVC/WebAPI.

[Tratcher]

Closing this now that we've worked through the main checklists. Further questions, feedback, etc. should be filed in new issues.

[Yves57]

@Tratcher Because SVG is a standard included in W3C recommandations. So I don't think it's "exotic"...