search

aspnet / BasicMiddleware

[Archived] Basic middleware components for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
169 stars 84 forks source link

Added support for the AbortRequest action #134

Closed mikaelm12 closed 8 years ago

mikaelm12 commented 8 years ago

Background of the AbortRequest action

An AbortRequest action causes the URL Rewrite Module to drop the HTTP connection for the current request. The action does not have any parameters. Use of this action implies that no subsequent rules are evaluated for the current URL after this action is performed.

I also added an example to the sample. @Tratcher @natemcmaster

Tratcher commented 8 years ago

Is there an issue tracking this feature work?

mikaelm12 commented 8 years ago

@Tratcher It's listed in the check list in https://github.com/aspnet/BasicMiddleware/issues/67 but no dedicated issue for just this feature. Should I open one?

Tratcher commented 8 years ago

Yeah, there's few enough left on that list that we can open a bug for each (that we think are even possible) and triage them appropriately. There's already a bug for maps.

No fixing bugs that aren't assigned to the current milestone :-)

natemcmaster commented 8 years ago

Implementation looks good to me. I'll let Chris do final sign off.

Tratcher commented 8 years ago

@muratg for triage.

muratg commented 8 years ago

Agreed with @Tratcher that we should file a bug for each remaining item and close #67. As of this one, this can wait till later. We'll triage once we ship preview1.

mikaelm12 commented 8 years ago

Rebased on dev. Can we check this in? @muratg @Tratcher

muratg commented 8 years ago

https://github.com/aspnet/BasicMiddleware/issues/136 triaged in 1.1.