search

aspnet / BasicMiddleware

[Archived] Basic middleware components for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
169 stars 84 forks source link

Fixed Enable and negate flag issue. #140

Closed mikaelm12 closed 7 years ago

mikaelm12 commented 7 years ago

For issues https://github.com/aspnet/BasicMiddleware/issues/138 and https://github.com/aspnet/BasicMiddleware/issues/139.

I also made the middleware throw when global rules are present since we don't actually handle them properly with the current implementation.

@Tratcher @muratg @BrennanConroy

BrennanConroy commented 7 years ago

:shipit:

BrennanConroy commented 7 years ago

Actually, this doesn't fix the enabled issue, see Justin's comment on the issue. Also, add a couple tests

mikaelm12 commented 7 years ago

It does fix the enabled flag issue. Justin was mistaken

mikaelm12 commented 7 years ago

Ping @Tratcher @BrennanConroy

BrennanConroy commented 7 years ago

:shipit: