search

aspnet / BasicMiddleware

[Archived] Basic middleware components for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
169 stars 84 forks source link

patternSyntax parsing behavior #145

Closed BrennanConroy closed 7 years ago

BrennanConroy commented 7 years ago

Change WildCard to Wildcard https://github.com/aspnet/BasicMiddleware/blob/dev/src/Microsoft.AspNetCore.Rewrite/Internal/IISUrlRewrite/PatternSyntax.cs#L9 OR Parse the Enum ignoring case https://github.com/aspnet/BasicMiddleware/blob/dev/src/Microsoft.AspNetCore.Rewrite/Internal/IISUrlRewrite/UrlRewriteFileParser.cs#L64

@mikaelm12

BrennanConroy commented 7 years ago

Also look at the other Enums like MatchType, found examples of both uppercase and camelCase on the interwebz

mikaelm12 commented 7 years ago

We should definitely change the WildCard enum to Wildcard for consistency with the Url Rewrite reference doc and I think that we should also do case insensitive parsing of enums.

Thoughts @Tratcher @natemcmaster ?

natemcmaster commented 7 years ago

... change the WildCard enum to Wildcard for consistency with the Url Rewrite reference doc and I think that we should also do case insensitive parsing of enums.

Yes to both.

mikaelm12 commented 7 years ago

Fixed in https://github.com/aspnet/BasicMiddleware/pull/160