aspnet / BasicMiddleware

[Archived] Basic middleware components for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
169 stars 84 forks source link

Fixed exception messages for server variable parsing #150

Closed mikaelm12 closed 7 years ago

mikaelm12 commented 7 years ago

Main thing here is that some of the exception messages for the server variable parsing was incorrect as pointed out in https://github.com/aspnet/BasicMiddleware/issues/143. I also did some refactoring to make the server variable parsing for IIS Url rewrite and Apache mod rewrite a little more similar.

Not urgent, just thought I'd open the pr.

@BrennanConroy @Tratcher @natemcmaster @muratg

mikaelm12 commented 7 years ago

@muratg Is this okay to merge to dev, or should we wait?

muratg commented 7 years ago

@mikaelm12 yeah, it should be OK to merge to dev.