search

aspnet / BasicMiddleware

[Archived] Basic middleware components for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
169 stars 84 forks source link

Url Rewrite conditions shouldn't require a pattern attribute #159

Closed mikaelm12 closed 7 years ago

mikaelm12 commented 7 years ago

Right now if you don't pass in a pattern attribute for each condition the file parser throws. This behavior is incorrect. For example it break the isFile and isDirectory checks <add input="{REQUEST_FILENAME}" matchType="isFile" negate="true"> wont work.

mikaelm12 commented 7 years ago

Turns out that this is an issue with case insensitive enum parsing. The IsFile and the IsDirectory enums should be isFile and isDirectory . We should also do case insensitive enum parsing. Previously filed in https://github.com/aspnet/BasicMiddleware/issues/145