search

aspnet / BasicMiddleware

[Archived] Basic middleware components for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
169 stars 84 forks source link

Boolean parsing accepts bad values #161

Closed mikaelm12 closed 7 years ago

mikaelm12 commented 7 years ago

The Url rewrite file parser accepts bad values for the boolean attributes and just uses default values. Default should only be used when no value is given, we should throw for bad values

ex. https://github.com/aspnet/BasicMiddleware/blob/c0425c62536d9727ad7ceb02d62d5b21ec33e901/src/Microsoft.AspNetCore.Rewrite/Internal/IISUrlRewrite/UrlRewriteFileParser.cs#L89-L93