Fix url rewrite bool parsing

aspnet / BasicMiddleware

[Archived] Basic middleware components for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore

Apache License 2.0

169 stars 84 forks source link

Closed mikaelm12 closed 8 years ago

mikaelm12 commented 8 years ago

Fixes https://github.com/aspnet/BasicMiddleware/issues/161 This change makes url rewrite file parsing throw for bad values for Boolean parameters and only provides defaults when the attributes aren't present.

@Tratcher @natemcmaster @BrennanConroy

mikaelm12 commented 8 years ago

@Tratcher I'll open a new PR to clean up the enum parsing (making it similar to how the bool parsing is done here).

Tratcher commented 8 years ago

Go ahead and fix the Enum pattern in this PR, they're related.

mikaelm12 commented 8 years ago

Updated @Tratcher

mikaelm12 commented 8 years ago

@Tratcher Updated to use generics. Cut out a lot of the similar methods.