#59 add IIS global rules support with tests

aspnet / BasicMiddleware

[Archived] Basic middleware components for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore

Apache License 2.0

169 stars 84 forks source link

#59 add IIS global rules support with tests #169

Closed david-peden-q2 closed 7 years ago

david-peden-q2 commented 8 years ago

i did not add a test for the actual middleware execution. there currently aren't any and i didn't want to introduce any sort of additional dependencies (mock frameworks, integration tests, etc.) as a part of this PR. as the middleware is written, it's somewhat difficult to get at the part of the code that was modified. i suspect that you guys will have feedback on this part anyway. ;)

dnfclas commented 8 years ago

Hi @david-peden-q2, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks! We will now validate the agreement and then real humans will evaluate your PR.

TTYL, DNFBOT;

Tratcher commented 8 years ago

Thanks for the PRs. FYI we're wrapping up a milestone right now so we'll come back to this for the next milestone.