search

aspnet / BasicMiddleware

[Archived] Basic middleware components for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
169 stars 84 forks source link

#183 add support for custom request/response headers via server variables #184

Closed davidpeden3 closed 7 years ago

dnfclas commented 7 years ago

Hi @davidpeden3, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

jkotalik commented 7 years ago

Thanks for all the contributions; I'll get to looking at these later today 🐐

davidpeden3 commented 7 years ago

@jkotalik i have them all implemented in an actual reverse proxy that we're running and implemented everything that we needed to migrate away from IIS/ARR. as you have noted elsewhere, documentation on how things should work is sparse so i've emulated the behavior we've observed in IIS/ARR and written tests to back that up. undoubtedly there will be holes but the PRs should at least get the ball rolling.

davidpeden3 commented 7 years ago

@Tratcher @jkotalik i made the easy changes. i probably won't be able to get to the more involved stuff until wed or next week, unfortunately.

davidpeden3 commented 7 years ago

ok, was able to knock out everything else. let me know if i missed anything.

davidpeden3 commented 7 years ago

@Tratcher back from vacation and was going to resume work on these PRs. started off with attempting to sync my fork with dev. i've run into a snag.

https://github.com/aspnet/BasicMiddleware/blob/dev/global.json#L6

does not appear to be a publicly available version of the sdk. i am running 1.0.0-preview2-1-003177 locally and that's what's available from:

https://www.microsoft.com/net/download/core#/current

i tried just changing the value to build 3177 but i get over 200 compilation errors related to Task. E.g.,:

Error   CS0433  The type 'Task' exists in both 'System.Threading.Tasks, Version=4.0.10.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'System.Runtime, Version=4.2.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' Microsoft.AspNetCore.HttpOverrides.Tests    C:\temp\BasicMiddleware\test\Microsoft.AspNetCore.HttpOverrides.Tests\ForwardedHeadersMiddlewareTest.cs 18

None of which are in my code. This also happens on a fresh clone of dev that does not have any of my code. I'm not sure what the issue is nor how to proceed. Any advice would be appreciated.

Tratcher commented 7 years ago

Working against the dev can be hard when we take the latest CLI builds. Start by running build.cmd from the command line. That is self-contained and pulls all of the dependencies it needs. If that works then you can modify your machine path to remove C:\Program Files\dotnet and add C:\Users\{username}\appdata\local\Microsoft\dotnet. Then VS should be able to find the latest CLI version installed by build.cmd.

davidpeden3 commented 7 years ago

great, thanks. i'll give that a shot.

edit: worked, thanks!

davidpeden3 commented 7 years ago

@mikaelm12 i have not resolved the last comment that @Tratcher made. been tied up at work and need to chew on it some more to better understand what changes i should make.

mikaelm12 commented 7 years ago

Closing this for now since there is still a significant amount of work left and it has become stale. Still happy to continue reviewing this though!