search

aspnet / BasicMiddleware

[Archived] Basic middleware components for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
169 stars 84 forks source link

RE: Lack of parity between ServerVariables with URL Rewriting Middleware #195

Closed guardrex closed 7 years ago

guardrex commented 7 years ago

Just working on the doc sample and noticed that SERVER_PORT is offered for mod_rewrite bits but not IIS bits. I'm sure there are good reasons why some parity might not be present [just WIP?], but why is something so basic as SERVER_PORT not available on the IIS-side of the middleware?

Reference:

ServerVariables mod_rewrite-side ServerVariables IIS-side

cc: @mikaelm12 @jkotalik ... especially on the point that I plan to list the supported variables in a reference section ~at the bottom of the doc~ somewhere in there. There's no point in devs trying to guess what's supported imo. Missing something like SERVER_PORT (and others commonly used but not available) will be confusing for many when they go to use the middleware.

guardrex commented 7 years ago

This should be (mostly*) fixed by https://github.com/aspnet/BasicMiddleware/pull/184/

(mostly*) ... I don't see SERVER_PORT for example, but I guess the lack of parity is a known issue by the team.