search

aspnet / BasicMiddleware

[Archived] Basic middleware components for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
169 stars 84 forks source link

Add a Brotli Compression Provider #217

Closed RehanSaeed closed 6 years ago

RehanSaeed commented 7 years ago

This great post by Tomasz Pęczek shows how to add Brotli compression today using Brotli.NET which is a .NET wrapper around the native Brotli DLL. ASP.NET Core has made a big deal about performance, this should be a higher priority.

Related issue 'Add a Priority to each Response Compression Provider' would also need to be addressed.

jbayardo commented 7 years ago

Might want to use the version in CoreFX Labs for this: https://dotnet.myget.org/feed/dotnet-corefxlab/package/nuget/System.IO.Compression.Brotli

muratg commented 7 years ago

@jkotalik This is not ready yet, but will be once CoreFX packages are in a usable state.

cc @joshfree FYI

joshfree commented 7 years ago

Yes, this is one of the next things @ianhays will be working on. https://github.com/dotnet/corefx/issues/24826

jkotalik commented 6 years ago

https://github.com/dotnet/corefx/issues/24826 was just finished. We can consume this soon. @muratg we still want to target this for 2.1, correct?

muratg commented 6 years ago

@jkotalik possibly, but we'll need to prioritize it with other items.

cc @glennc

ianhays commented 6 years ago

Out of curiosity, @muratg are you still planning on including brotli support for 2.1 by consuming the CoreFX Brotli library being added in .net core 2.1?

FYI: @joshfree

muratg commented 6 years ago

@ianhays It's not currently in 2.1 list. cc @DamianEdwards

joshfree commented 6 years ago

It would be nice if ASP.NET Core exposed this in 2.1 if there's still time.

https://github.com/dotnet/corefx/issues/25785

DamianEdwards commented 6 years ago

I'd love for us to have this in 2.1, but there are other items ahead of it right now and given where we are it seems unlikely we'll get it in.

joshfree commented 6 years ago

@muratg @glennc can you prioritize completing this work for .NET Core 2.2?

muratg commented 6 years ago

@joshfree I don't think anything changed since @DamianEdwards's comment. He owns the priorities.

khellang commented 6 years ago

This should be a quick pull request from the community, right?

RehanSaeed commented 6 years ago

Might not be as simple as you think. To do this, https://github.com/aspnet/BasicMiddleware/issues/216 also needs to be implemented.

Tratcher commented 6 years ago

To make it useful that is...

tpeczek commented 6 years ago

Also the fact that System.IO.Compression.Brotli (unless I've missed something) is .NET Core only, might be a challenge (different functionality between platforms).

joshfree commented 6 years ago

Thanks folks for getting this into the 2.2 milestone!